Actually three raccoons in a trench coat.

Owner and proprietor of the Demonologic Porn Shed (!demonologic@lemmynsfw.com).

Lesbian or lesbian-adjacent, and a pretty girl enthusiast. A “they” or “she” – I guess I’m a themme?

Feel free to DM me!

  • 33 Posts
  • 59 Comments
Joined 9 months ago
cake
Cake day: November 4th, 2023

help-circle



  • Oh yes but my point is that even though I know that the order in the file picker is correct, the result often isn’t. Out of curiosity I just had to check how lemmy-ui does things, and turns out I was essentially right about how the uploads are done: looking at the markdown textarea source, each upload is turned into Markdown and added into the comment body as soon as it finishes (in uploadSingleImage). Wouldn’t even be all that hard of a fix I think, let’s see if I’ll find the energy to make a throwaway github account and make a PR out of this 😅


  • Honestly could be, it’s been a while since I had to touch web UI code. I had a vague memory that at least in Firefox and Chrome file pickers give their resulting FileList in the same order as the files were in the native picker dialog. My gut feeling is that there’s a for … of loop somewhere in lemmy-ui that goes through the file list returned by the picker, and starts an upload for each file so that each upload’s completion handler adds the newly-minted image’s markdown to the comment. It really does feel like the order is based on whichever upload finishes first, because often the order is sort of correct but not quite.